Learn Recursion by Building a Decimal to Binary Converter - Step 33

JavaScript
1

Tell us what’s happening:

Describe your issue in detail here.

Your code so far

<!-- file: index.html -->
<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="UTF-8" />
    <meta http-equiv="X-UA-Compatible" content="IE=edge" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>Decimal to Binary Converter</title>
    <link rel="stylesheet" href="styles.css" />
  </head>
  <body>
    <h1>Decimal to Binary Converter</h1>
    <div class="input-container">
      <label for="number-input">Enter a decimal number:</label>
      <input
        value=""
        type="number"
        name="decimal number input"
        id="number-input"
        class="number-input"
      />
      <button class="convert-btn" id="convert-btn">Convert</button>
    </div>
    <output id="result" for="number-input"></output>
    <div id="animation-container"></div>
    <script src="script.js"></script>
  </body>
</html>

/* file: styles.css */
*,
*::before,
*::after {
  box-sizing: border-box;
  margin: 0;
  padding: 0;
}

:root {
  --light-grey: #f5f6f7;
  --dark-blue: #1b1b32;
  --orange: #f1be32;
}

body {
  background-color: var(--dark-blue);
  font-family: "Times New Roman", Times, serif;
  font-size: 18px;
  color: var(--light-grey);
  padding: 0 15px;
  display: flex;
  flex-direction: column;
  align-items: center;
}

h1 {
  text-align: center;
  font-size: 2.3rem;
  margin: 20px 0;
}

.input-container {
  margin: 10px 0;
  display: flex;
  flex-direction: column;
  gap: 10px;
  justify-content: center;
  align-items: center;
}

.convert-btn {
  background-color: var(--orange);
  cursor: pointer;
  border: none;
  padding: 4px;
}

.number-input {
  height: 25px;
}

#result {
  margin: 10px 0;
  min-width: 200px;
  width: fit-content;
  min-height: 80px;
  word-break: break-word;
  padding: 15px;
  border: 5px solid var(--orange);
  font-size: 2rem;
  text-align: center;
}

#animation-container {
  margin: auto;
  max-width: 300px;
}

.animation-frame {
  margin: 250px auto 0;
  padding: 15px 10px;
  border: 5px solid var(--orange);
  font-size: 1.2rem;
  text-align: center;
}

@media screen and (min-width: 500px) {
  .input-container {
    flex-direction: row;
  }

  #result {
    max-width: 460px;
  }
}

/* file: script.js */
const numberInput = document.getElementById("number-input");
const convertBtn = document.getElementById("convert-btn");
const result = document.getElementById("result");

const decimalToBinary = (input) => {
  const inputs = [];
  const quotients = [];
  const remainders = [];

  while (input > 0) {
    const quotient = Math.floor(input / 2);
    const remainder = input % 2;

    inputs.push(input);
    quotients.push(quotient);
    remainders.push(remainder);
    input = quotient;
  }

  console.log("Inputs: ", inputs);
  console.log("Quotients: ", quotients);
  console.log("Remainders: ", remainders);


// User Editable Region

  remainders.reverse().join("")
  result.innerText = remainders

// User Editable Region

};

const checkUserInput = () => {
  if (!numberInput.value || isNaN(parseInt(numberInput.value))) {
    alert("Please provide a decimal number");
    return;
  }

  decimalToBinary(parseInt(numberInput.value));
  numberInput.value = "";
};

convertBtn.addEventListener("click", checkUserInput);

numberInput.addEventListener("keydown", (e) => {
  if (e.key === "Enter") {
    checkUserInput();
  }
});

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 YaBrowser/24.1.0.0 Safari/537.36

Challenge Information:

Learn Recursion by Building a Decimal to Binary Converter - Step 33


  remainders.reverse().join("")
  result.innerText = remainders

not work

2

You appear to have created this post without editing the template. Please edit your post to Tell us what’s happening in your own words.

3

Please talk to us about what isn’t working and how the instructions or error message is confusing. Thanks

4

I don’t know how to explain them, they are very difficult to understand, I just read and wrote the code, but nothing worked

1 Like
5

It’s pretty hard to help if you can’t be somehow specific.

This line isn’t doing anything with the string it creates. What’s this for?

1 Like
6

I thought it was the remainder that is turned over and connected as indicated in the instructions,

7

from such training it is impossible to understand how everything works here, so for myself I only look at how to write code and nothing more

1 Like
8

If it’s impossible for you to understand, you should try a curriculum written in Russian

9

But you didn’t use the result anywhere. If you create a value and don’t use it, it’s not helping you. So what are you supposed to do with this value?

10

I understand everything in Russian, I went there and studied

11

I use the result because I assign the remainder

12

reverse changes the thing it is used on.
join doesn’t change the thing it is used on, join returns a new string. The new string is not saved anywhere and is lost to the void.

1 Like
13

Except you aren’t using the result.

Line 1 creates a string and throws it away.

Line 2 sets the innerText equal to the remainders array

14

If you already understand everything, then why do you need this course?

15

Well, personally, nothing is clear here

16

as always, such explanations will never be understood

17

If you understand nothing in this curriculum, you are under no obligation to use it at all

18

what part is confusing for you?

19

Am I writing down wrong join?

20

You aren’t using the result of the .join in any way. It isn’t stored in a variable or returned